Graylog2 / collector-sidecar

Manage log collectors through Graylog
https://www.graylog.org/
Other
268 stars 56 forks source link

Add upgrade support and improve windows installer #447

Closed mpfz0r closed 1 year ago

mpfz0r commented 1 year ago

The installer can now also upgrade existing sidcar installations. It detects this by the presence of an existing sidecar.yml config. In upgrade mode it skip the configuration page.

Additionally the installer will now also register the sidecar service automatically. Making this extra command line step obsolete.

For debugging purposes, we write a installerlog.txt file now.

Improve welcome message test to also show the version and mention the autmatic upgrade mode.

Only replace the winlogbeat and filebeat collector binaries AFTER we stopped the sidecar. Otherwise the files might still be locked and the upgrade fails.

Suppport -NODEID param for silent installer Also fix default node-id file location for 32-bit installs

Fixes #365 Fixes #432

mpfz0r commented 1 year ago

Would be nice if we could fix that.

@thll I agree, but I was running out of time and wasn't sure if it's worth the effort. @boosty what do you think. should we spend more time on this?

boosty commented 1 year ago

@mpfz0r Depends on how hard it is to fix. A few hours during this cool-down seem ok to me.