Graylog2 / collector-sidecar

Manage log collectors through Graylog
https://www.graylog.org/
Other
268 stars 56 forks source link

Sidecar hangs during restart #463

Closed danotorrey closed 1 year ago

danotorrey commented 1 year ago

[HS 1308449306]

Problem description

When attempting to restart a Sidecar, the restart process hangs and gets stuck in an infinite loop if the shutdown of the sidecar takes more than 5 seconds.

A possible source of the issue is here, where a 5 second timeout is hard-coded: https://github.com/Graylog2/collector-sidecar/blob/1.3/daemon/exec_runner.go#L264

The problem might also be compounded by large sidecar configurations.

Environment

mpfz0r commented 1 year ago

Fixed with #462