Check if CMS GC JAVA_OPTs are available before using them.

malcyon commented 3 years ago

In order to support Java 15, we need to check whether the JAVA_OPTs for the CMS Garbage Collector are available or not.

Related to: Graylog2/graylog2-server#10275

I copied the structure of #87 to see which changes needed to be made.

malcyon commented 3 years ago

I tested it with Java 1.8 and Java 15 and both cases look good. Here is how I tested it:

Used Ansible role to spin up Graylog/Elasticsearch/Mongo in Vagrant (Ubuntu 20.04 with Java 1.8)
Uninstalled graylog-server package
copied custom build .deb into vagrant
installed new graylog-server deb
In the install prompts, I overrode the preexisting /etc/default/graylog-server and used the file from the package.
started graylog and validated that it started up correctly
validated that all three CMS JAVA_OPTs are there using ps -ef | grep java.
stop graylog-server
Install JDK 15
start graylog-server
Tail log and ensure graylog-server starts properly.
Run ps -ef | grep java and ensure CMS JAVA_OPTs are not being passed.

malcyon commented 3 years ago

I also tested the RPM on Centos 7, using the above method. Everything looks good there, too.

Graylog2 / fpm-recipes