Move number of worker threads to configuration

Graylog2 / gelfclient

GELF client library for Java based on Netty 4

https://www.graylog.org/

Apache License 2.0

38 stars 19 forks source link

Move number of worker threads to configuration #35

Closed Aloren closed 6 years ago

CLAassistant commented 6 years ago

All committers have signed the CLA.

coveralls commented 6 years ago

Coverage decreased (-0.9%) to 81.278% when pulling 54beb2bf50b7ba2d01137c76f8396c7c43a2f4c8 on Aloren:feature/move-threads-to-config into 8d2685e0a4c26a4b2037a706a6fee02aed7a611c on Graylog2:master.

coveralls commented 6 years ago

Coverage decreased (-0.5%) to 81.718% when pulling 4292b85ba1d04e0564507af9f990707e076aba3d on Aloren:feature/move-threads-to-config into e67a36bcd99b4480d884f23901d2807098e751cc on Graylog2:master.

Aloren commented 6 years ago

@joschi thanks for review! I've added simple test for configuration, but I'm not sure how to test correct initialization of AbstractGelfTransport? I've also rebased to current master.

joschi commented 6 years ago

@Aloren I guess it's good enough for now.

Thanks a lot for your contribution!