search

Graylog2 / graylog-ansible-role

Ansible role which installs and configures Graylog
Apache License 2.0
212 stars 126 forks source link

Many deprecation warnings with current ansible version #117

Closed sjwk closed 4 years ago

sjwk commented 5 years ago

Running the role with the current stable version of ansible gives a number of deprecation warnings, some of which for behaviour which is due to be removed in the next release. Some examples:

`TASK [graylog2.graylog-ansible-role : Package 'apt-transport-https' should be installed] ***

instead.. This feature will be removed in version 2.9. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. `

TASK [graylog2.graylog-ansible-role : Ensure Java is installed] **************** [DEPRECATION WARNING]: evaluating graylog_install_java as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

TASK [graylog2.graylog-ansible-role : Discover systemd capabilities] *********** [DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using result|version_compareuseresult is version_compare. This feature will be removed in version 2.9. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

L1ghtn1ng commented 5 years ago

From what I have seen this is due to the elasticsearch role and not graylog role so it is a different upstream issue

danielmorlock commented 4 years ago

From what I have seen this is due to the elasticsearch role and not graylog role so it is a different upstream issue

I don't think so: graylo2.graylog-ansible-role requires elastic.elasticsearch-6.6.0 as dependency which inherits deprecated filters i.e. version_compare. So with a recent ansible 2.9+ this role cannot be used as is.

danielmorlock commented 4 years ago

The task "Discover systemd capabilities" of role graylog-ansible-role is also using the deprecated version_compare filter:


TASK [Graylog2.graylog-ansible-role : Discover systemd capabilities] ***************************************************************************************************************************************************************************************************************************************************
fatal: [logging-p-1]: FAILED! => {"msg": "template error while templating string: no filter named 'version_compare'. String: {{\n  (ansible_distribution == 'Debian' and ansible_distribution_version | version_compare('8', '>=')) or\n  (ansible_distribution in ['RedHat','CentOS'] and ansible_distribution_version
| version_compare('7', '>=')) or\n  (ansible_distribution == 'Ubuntu' and ansible_distribution_version | version_compare('15', '>='))\n}}\n"}
danielmorlock commented 4 years ago

I just found out that this is already addresses here https://github.com/Graylog2/graylog-ansible-role/commit/0ca1c6b35071697319cda05482348a4619d0188a.

malcyon commented 4 years ago

I believe this is all updated now.