search

Graylog2 / graylog-ansible-role

Ansible role which installs and configures Graylog
Apache License 2.0
212 stars 126 forks source link

dashes in role names are not allowed by ansible #178

Closed reduzent closed 3 years ago

reduzent commented 3 years ago

According to https://galaxy.ansible.com/docs/contributing/creating_role.html#role-names --characters should not be used in ansible roles. I understand that it was common to prefix role names with andible-role- in Galaxy. Thus, the documentation suggests to add an extra field to meta/main.yml:

galaxy_info:
  role_name: graylog
malcyon commented 3 years ago

Leaving this open until I get time to release it and make sure it's right.

malcyon commented 3 years ago

Okay, I cut a new release with this change. We are now located at:

https://galaxy.ansible.com/Graylog2/graylog

I hate that the old url (https://galaxy.ansible.com/Graylog2/graylog-ansible-role) is now a dead link. Not even a redirect! This will break anyone trying to pull the role using the old name.

BUT, I upgraded Ansible on my machine yesterday and it was giving me errors because of the dashes in the name. Applying this fix was the only thing that would let me run it.

It seems like the naming standards changed out from under us over the years. I hate breaking changes, but hopefully this is defensible.

dragona-Ocient commented 2 years ago

We don't use the galaxy role, this was our own role.