[+] Add a initial content pack settings

Graylog2 / graylog-ansible-role

Ansible role which installs and configures Graylog

Apache License 2.0

212 stars 127 forks source link

[+] Add a initial content pack settings #185

Closed sahya closed 2 years ago

sahya commented 2 years ago

Hi, there.

I noticed a lack of configuration in templates/graylog.server.conf.j2. So I propose this configuration when I referenced [git.codificar.com.br/diogo.coutinho] this config.

Detail; The add settings are not contained the template of graylog.server.conf.j2 whether contained the default config parameter defaults/main.yml#L120-L123.

My Graylog version is 4.2. If it needs to consider under the 3.0 version for lower compatibility, Let me know it. And if you have some idea, could you tell me it?

Notes for Reviewers

[ ] The commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge
[ ] Sync up with the author before merging

CLAassistant commented 2 years ago

All committers have signed the CLA.

sahya commented 2 years ago

@malcyon @mariussturm Hi, I'm sorry to mention you. Could you treat this pull request?

malcyon commented 2 years ago

Hi @sahya,

My apologies for the delay. This change looks good to me.

Could you sign the Contributor License Agreement? I see the license/cla check isn't completed yet.

sahya commented 2 years ago

@malcyon, I appreciate for reviewing this PR.

Please sign the CLA and I will approve.

I just signed CLA for the first time. I was a little bit of a worried mind.

Excuse me, I have a question about lower compatibility. I think my written code doesn't consider the lower compatibility. So if it needs to consider under the 3.0 version for lower compatibility, Let me know it. And if you have some idea, could you tell me it?

malcyon commented 2 years ago

Excuse me, I have a question about lower compatibility. I think my written code doesn't consider the lower compatibility. So if it needs to consider under the 3.0 version for lower compatibility, Let me know it. And if you have some idea, could you tell me it?

I'll test it out and see. I think Graylog ignores any properties it doesn't understand.

malcyon commented 2 years ago

I was able to spin up Graylog 3.3.15 successfully using this. No errors in the logs. It seems to work just fine.

Thanks for the contribution!

sahya commented 2 years ago

@malcyon

Excuse me, I have a question about lower compatibility. I think my written code doesn't consider the lower compatibility. So if it needs to consider under the 3.0 version for lower compatibility, Let me know it. And if you have some idea, could you tell me it?

I'll test it out and see. I think Graylog ignores any properties it doesn't understand.

Okay, I understood it.

I appreciate you that are reviewing and testing the code. Thank you.