search

Graylog2 / graylog-ansible-role

Ansible role which installs and configures Graylog
Apache License 2.0
212 stars 127 forks source link

fix set proxy settings as comment with a conditional check in the j2 … #188

Closed xtruthx closed 2 years ago

xtruthx commented 2 years ago

Add conditional to the Jinja2 template for server.conf to avoid that proxy settings are set as comment. Closes #187

xtruthx commented 2 years ago

now it should be correct, sorry about the first wrong varname copy.

mariussturm commented 2 years ago

Hey, thanks for the contribution! Looks good only the indentation is off. Could you please do it like it's done for the other conditions, e.g.: https://github.com/Graylog2/graylog-ansible-role/blob/bb94e9f224ccd64af634ae59c1959c9d06d78686/templates/graylog.server.conf.j2#L176

Thank you!

xtruthx commented 2 years ago

Thx @mariussturm i removed the identation.

mariussturm commented 2 years ago

Cool, thank you very much!

xtruthx commented 2 years ago

Your welcome, thx for the fast response.