Update configuration to match version 2.1.1

Graylog2 / graylog-ansible-role

Ansible role which installs and configures Graylog

Apache License 2.0

212 stars 127 forks source link

Update configuration to match version 2.1.1 #50

Closed veger closed 7 years ago

veger commented 7 years ago

I did the following:

grabbed /etc/graylog/server/server.conf from the Debian package (version 2.1.1-2) and matched the graylog.server.conf.j2 to it.
removed unused defaults and added the new ones.
updated graylog.server.elasticsearch.yml.j2 since graylog_elasticsearch_node_name got replaced by elasticsearch_node_name_prefix (see http://docs.graylog.org/en/2.1/pages/upgrade/graylog-2.0.html).

CLAassistant commented 7 years ago

All committers have signed the CLA.

danvaida commented 7 years ago

@veger can you please adhere to the standards of the repo regarding the syntax? see reasoning here https://github.com/Graylog2/graylog-ansible-role/pull/47#issuecomment-255474841

mariussturm commented 7 years ago

@danvaida could you please point to one or two lines with syntax validations as examples. I want to merge this soon.

veger commented 7 years ago

I updated the # Web UI part of defaults/main.yml

If there are other issues, either with formatting or something else, please let me know

veger commented 7 years ago

Updated your mentioned syntax errors, including some additional/similar, as a separate commit (for reviewing purposes). If you want to have the commits combined, please let me know.

mariussturm commented 7 years ago

Ok thanks! The idea was to quote True/False when it's used in a template to signal that it will re rendered somewhere but when it's used internally it's not. Like the install switches, will fix that.

veger commented 7 years ago

Ah... now I understand the reasoning/difference. Thanks