Graylog2 / graylog-docker

Official Graylog Docker image
https://hub.docker.com/r/graylog/graylog/
Apache License 2.0
361 stars 133 forks source link

forwarder: consider usage of tini #138

Closed jalogisch closed 3 years ago

jalogisch commented 3 years ago

We need to consider using tini ( https://github.com/krallin/tini ) in the forwarder image.

It can be installed as package ( https://github.com/Graylog2/graylog-docker/blob/4.0/docker/oss/Dockerfile#L87 ) and called easy ( https://github.com/Graylog2/graylog-docker/blob/4.0/docker/oss/Dockerfile#L129 ) but would gain some additional features:

All Tini does is spawn a single child (Tini is meant to be run in a container), and wait for it to exit all the while reaping zombies and performing signal forwarding.

Not sure if we need that in the forwarder, but that is currently mostly default for lot of images and does not harm at all.