search

Graylog2 / graylog-plugin-auth-sso

SSO support for Graylog through trusted HTTP headers set by load balancers or authentication proxies
Other
50 stars 13 forks source link

Add user defined groups to default group option #19

Closed twgraham closed 7 years ago

twgraham commented 7 years ago

This PR gives the ability to choose from user defined groups in the 'default group' option when users first authenticates with SSO. My motivation for this was that OOB reader was too restrictive, Admin was too permissive, and it causes more manual overhead to modify individuals roles

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

twgraham commented 7 years ago

Signed the CLA.

twgraham commented 7 years ago

Apologies for the extra commits... I did test this thoroughly, I just had to commit from another machine.

bernd commented 7 years ago

@twgraham Thank you for the PR! We are going to review this soon! :smiley:

kroepke commented 7 years ago

Sorry for the delay, as this plugin isn't shipped with the main bundle, I'll review this after the bulk of 2.2 work is done and I have a bit more time.

Thank you for your patience!

twgraham commented 7 years ago

@kroepke no worries! Excited for 2.2. Keep in mind that this PR was made on 2.1.x. Not sure if relevant API's might've changed in 2.2 - i try building and testing and let you know.

kroepke commented 7 years ago

@twgraham The APIs should be the same :)

bernd commented 7 years ago

@twgraham Sorry for the very long delay. This has been merged now. Thank you very much!

twgraham commented 7 years ago

@bernd no worries, thanks for getting it in :)