search

Graylog2 / graylog-plugin-integrations

A collection of open source Graylog integrations that will be released together.
Other
14 stars 14 forks source link

Remove extra declaration of AWS SDK version #1310

Closed danotorrey closed 1 year ago

danotorrey commented 1 year ago

While updating the Java SDK version, I noticed the extra declaration of the version in this repo, which I don't think is needed. The server declaration of the property should be used now.

/jenkins-pr-deps Graylog2/graylog2-server#14712,Graylog2/graylog-plugin-enterprise#4727 /nocl

kingzacko1 commented 1 year ago

This change causes a test to fail, but it appears to be expected with a new AWS SDK version: 

[2023-02-17T17:49:42.135Z] [INFO] Results:
[2023-02-17T17:49:42.135Z] [INFO] 
[2023-02-17T17:49:42.135Z] [ERROR] Failures: 
[2023-02-17T17:49:42.135Z] [ERROR]   AWSServiceTest.regionTest:144 There should be 28 total regions. This will change in future versions of the AWS SDK expected:<28> but was:<34>
[2023-02-17T17:49:42.135Z] [INFO] 
[2023-02-17T17:49:42.135Z] [ERROR] Tests run: 140, Failures: 1, Errors: 0, Skipped: 3
danotorrey commented 1 year ago

Thanks for seeing that @kingzacko1. I just pushed up a commit that makes that test more flexible. Hopefully now that does not need to be updated with each SDK update. Let me know if you see any issues with that.