search

Graylog2 / graylog-plugin-integrations

A collection of open source Graylog integrations that will be released together.
Other
14 stars 14 forks source link

Slack Plugin - Code Refactoring #611

Open lingpri opened 4 years ago

lingpri commented 4 years ago
  1. execute method remove the call for validate method.
  2. Slack client needs its own SlackClientException similar to PagerDutyClientException.
  3. Update junit tests accordingly.
  4. update severity of notifications, Urgent vs Normal

Reference Config validation happens when a user creates/modifies a Notification from the UI. It should not be possible for invalid config to exist at this point in processing.

_Originally posted by @waab76 in https://github.com/Graylog2/graylog-plugin-integrations/pull/595#discussion_r512238987_

lingpri commented 4 years ago

https://github.com/Graylog2/graylog-plugin-integrations/issues/610