Clean up integrations guice config for Forwarder

[waab76]

Enterprise Integrations has separate Guice configurations for Forwarder and non-Forwarder use cases. In the 4.0 release, some new Integrations plugins do not work in the Forwarder and thus we need a similar Guice split in Integrations. We should also double-check components in Enterprise Integrations.

Input Conditions

• None

Acceptance Criteria

• [ ] Cloud Forwarder is able to start with 4.0 codebase

Tasks

• [ ] Set up forwarder/server split in Integrations Guice module
• [ ] Move all Notifications (Integrations and Enterprise) to the server configuration
• [ ] Move all Outputs to the server configuration
• [ ] Move any Mongo-dependent Inputs to the server configuration
• [ ] Keep all non-Mongo-dependent Inputs in the Forwarder configuration

[malcyon]

I'm still seeing Guice errors when I try to run the forwarder with the integrations plugin.

I followed the instructions here to install the forwarder on a clean VM:

https://github.com/Graylog2/graylog-plugin-cloud/wiki/Forwarder#forwarder-operating-system-packages

Below are the logs from trying to start the service. Ignore the parts at the beginning where I didn't have Java installed yet.

service.log forwarder.log

If I remove the integrations plugin from the plugins folder, it starts just fine.

This is from a build this morning:

https://jenkins.ci.torch.sh/job/Release-Jobs/job/Graylog-Forwarder-Package-Build/115/console

[danotorrey]

@juju2112 I believe the backport of fix should fix this issue https://github.com/Graylog2/graylog-plugin-integrations/pull/693 since it puts the change on the cloud-4.0 branch. Can you please test once more after it is merged?

[malcyon]

@danotorrey Ah! I missed that. Okay, I'll check again once it's merged.

[malcyon]

@danotorrey I have the manifest using the 4.0 branch for this. Should I change it to cloud-4.0?

https://github.com/Graylog2/graylog-project-internal/blob/master/manifests/cloud/cloud-forwarder.json#L22-L23

[danotorrey]

@danotorrey I have the manifest using the 4.0 branch for this. Should I change it to cloud-4.0?

@juju2112 Yes, that should resolve it. cloud-4.0 should be used for both graylog-plugin-integrations and graylog-plugin-enterprise-integrations

Whenever the core devs create a new cloud-4.0 branch, we'll need to remember to update this manifest too.

Question: Should the manifest also have the -4.0 extension in the file name like the existing cloud-4.0.json manifest?

[malcyon]

Yeah, I can update that.

On Tue, Jan 5, 2021 at 2:12 AM Dan Torrey notifications@github.com wrote:

@danotorrey https://github.com/danotorrey I have the manifest using the 4.0 branch for this. Should I change it to cloud-4.0?

@juju2112 https://github.com/juju2112 Yes, that should resolve it. cloud-4.0 should be used for both graylog-plugin-integrations and graylog-plugin-enterprise-integrations

Whenever the core devs create a new cloud-4.0 branch, we'll need to remember to update this manifest too.

Question: Should the manifest also have the -4.0 extension in the file name like the existing cloud-4.0.json https://github.com/Graylog2/graylog-project-internal/blob/master/manifests/cloud/cloud-4.0.json manifest?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Graylog2/graylog-plugin-integrations/issues/675#issuecomment-754478649, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHAYT2PRPCCJC6XGPUFYVDSYLCV7ANCNFSM4UVODHSA .

[malcyon]

I cut a new release of the forwarder for the 4.0 branch, tested it on a fresh VM, and it starts up just fine.

[malcyon]

@danotorrey I also updated the graylog-forwarder docker image.

[danotorrey]

Great news. Thanks @juju2112