search

Graylog2 / graylog-plugin-map-widget

[DEPRECATED] Map widget for Graylog
https://www.graylog.org/
GNU General Public License v3.0
6 stars 12 forks source link

NPE during IP address lookup #67

Closed bernd closed 6 years ago

bernd commented 6 years ago

I have been running into this on one of my test setups. This looks like a missing null check somewhere in the data adapter.

We also might improve the log message to include the IP address for which the lookup failed to make it easier to reproduce issues like this one.

2018-01-20 04:08:04,094 WARN : org.graylog.plugins.map.geoip.MaxmindDataAdapter - Unable to look up IP address, returning empty result.
java.lang.NullPointerException: null
        at org.graylog.plugins.map.geoip.MaxmindDataAdapter.doGet(MaxmindDataAdapter.java:150) ~[?:?]
        at org.graylog2.plugin.lookup.LookupDataAdapter.get(LookupDataAdapter.java:123) ~[graylog.jar:?]
        at org.graylog2.lookup.LookupTable.lambda$lookup$0(LookupTable.java:72) ~[graylog.jar:?]
        at org.graylog2.lookup.caches.GuavaLookupCache$InstrumentedCache.get(GuavaLookupCache.java:239) [graylog.jar:?]
        at org.graylog2.lookup.caches.GuavaLookupCache.get(GuavaLookupCache.java:104) [graylog.jar:?]
        at org.graylog2.lookup.LookupTable.lookup(LookupTable.java:72) [graylog.jar:?]
        at org.graylog2.lookup.LookupTableService$Function.lookup(LookupTableService.java:534) [graylog.jar:?]
        at org.graylog2.inputs.extractors.LookupTableExtractor.run(LookupTableExtractor.java:71) [graylog.jar:?]
        at org.graylog2.plugin.inputs.Extractor.runExtractor(Extractor.java:214) [graylog.jar:?]
        at org.graylog2.filters.ExtractorFilter.filter(ExtractorFilter.java:77) [graylog.jar:?]
        at org.graylog2.messageprocessors.MessageFilterChainProcessor.process(MessageFilterChainProcessor.java:100) [graylog.jar:?]
        at org.graylog2.shared.buffers.processors.ProcessBufferProcessor.handleMessage(ProcessBufferProcessor.java:114) [graylog.jar:?]
        at org.graylog2.shared.buffers.processors.ProcessBufferProcessor.dispatchMessage(ProcessBufferProcessor.java:100) [graylog.jar:?]
        at org.graylog2.shared.buffers.processors.ProcessBufferProcessor.onEvent(ProcessBufferProcessor.java:86) [graylog.jar:?]
        at org.graylog2.shared.buffers.processors.ProcessBufferProcessor.onEvent(ProcessBufferProcessor.java:42) [graylog.jar:?]
        at com.lmax.disruptor.WorkProcessor.run(WorkProcessor.java:143) [graylog.jar:?]
        at com.codahale.metrics.InstrumentedThreadFactory$InstrumentedRunnable.run(InstrumentedThreadFactory.java:66) [graylog.jar:?]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_151]

Environment

Graylog version: 3.0.0-SNAPSHOT+6762727 Map widget version: 3.0.0-SNAPSHOT+55ebba4