Search query syntax check confuses quoted "not" with operator

Graylog2 / graylog2-server

Free and open log management

https://www.graylog.org

Other

7.33k stars 1.05k forks source link

Search query syntax check confuses quoted "not" with operator #13501

Open kroepke opened 1 year ago

kroepke commented 1 year ago

Expected Behavior

Quoted strings should not trigger the "wrong capitalization of boolean operator" warning.

Current Behavior

Possible Solution

Improve parser

Steps to Reproduce (for bugs)

Add some quoted text containing an "and", "not" etc
Submit the query
Observe the warning

Context

Misleading warning message.

Your Environment

Graylog Version: 4.3.7

todvora commented 1 year ago

I tried to reproduce the bug and can't find any problem. Is it possible, that the warning is a leftover from an old, outdated query?

todvora commented 1 year ago

Hey @kroepke , we have been able to reproduce it on 4.3 but not in newer versions. There have been several refactorings pushed meanwhile, so I assume that it has been fixed already. Do we need to backport that or are we OK with a fix in latest releases? Thanks!