Disable telemetry in local mode

bernd commented 1 year ago

Expected Behavior

The telemetry reporting should be disabled when the Graylog server runs in local mode. (--local)

Decision May 25th: Instead of completely disabling telemetry, we will configure it as follows:

local mode -> disable telemetry by default
smd.dev -> send events to Posthog Development project

Posthog Development project key: phc_N86WWkaKgfoywB57IFSbZNWCp1fsQ131yqMXMJRByqq
public release -> send events to Posthoh Production project

Posthog Production project key: phc_t3lgBB66QsPW4HEfiGopO14um4XGNtBcefEKYWelWda

Tasks

[ ] Disable telemetry when --local flag is used (equivalent to telemetry_enabled = false)
[ ] Disable telemetry when DEVELOPMENT environment variable is set and not value "false" (equivalent to telemetry_enabled = false) see IsDevelopmentServerProvider
[ ] Introduce a telemetry_dev_api_key config setting and set it to the PostHog dev key by default
[ ] Adjust code to check if the currently running Graylog version is a snapshot (-SNAPSHOT suffix)
- If the version is not a snapshot, use the telemetry_api_key value
- If the version is a snapshot, use the telemetry_dev_api_key

Current Behavior

The telemetry reporting is enabled even when Graylog is running in local mode.

Context

We run test and development setups in local mode. Submitting telemetry data for test and dev setups would produce lots of noise in the analysis of user behaviour in public environments .

Your Environment

Graylog Version: 5.1.0-beta.3

janheise commented 1 year ago

@bernd wondering about our Integration Tests and org.graylog.testing.graylognode.NodeContainerFactory? Do we have to fix these, too?

bernd commented 1 year ago

@bernd wondering about our Integration Tests and org.graylog.testing.graylognode.NodeContainerFactory? Do we have to fix these, too?

@janheise The telemetry only affects the frontend, as far as I know. The NodeContainerFactory is already disabling versionchecks via the GRAYLOG_VERSIONCHECKS environment variable.

janheise commented 1 year ago

@bernd at least for the reporting IT tests, we build and start the frontend, too.

bernd commented 1 year ago

@bernd at least for the reporting IT tests, we build and start the frontend, too.

@janheise Ah okay. I think we have an ongoing issue to disable telemetry for reporting in 5.1?

Graylog2 / graylog2-server