search

Graylog2 / graylog2-server

Free and open log management
https://www.graylog.org
Other
7.37k stars 1.06k forks source link

Prevent saving an Event Definition with Cardinality Aggregation without field specified. #18034

Open luk-kaminski opened 8 months ago

luk-kaminski commented 8 months ago

Prevent saving an Event Definition with Cardinality Aggregation without field specified.

Expected Behavior

Field should be mandatory for Cardinality Aggregation.

Current Behavior

You can save an Event Definition with Cardinality Aggregation ... without field specified: image

Possible Solution

Better validation, probably both BE and FE.

Steps to Reproduce (for bugs)

  1. Create or edit event definition.
  2. Choose: Create Events for Definition if... -> Aggregation of results reaches a threshold
  3. Pick cardinality, but do not choose a field.
  4. Notice you can save this kind of event definition.

Context

HS-2290625939

Your Environment

thll commented 8 months ago

Related to https://github.com/Graylog2/graylog2-server/issues/17367