search

Graylog2 / graylog2-server

Free and open log management
https://www.graylog.org
Other
7.41k stars 1.07k forks source link

New OpenSearch client does not return usable os() entry in NodeInfo #18652

Open mpfz0r opened 8 months ago

mpfz0r commented 8 months ago

NodeInfo#os() used to return a JsonNode which was serializable, and could be accessed for archiving.

We now return a org.opensearch.client.opensearch.nodes.info.NodeOperatingSystemInfo object which is not accessible outside the opensearch client.

This breaks Archiving and the infos collected for telemetry.

See comment here: https://github.com/Graylog2/graylog2-server/pull/17998/files#r1526099476

janheise commented 7 months ago

archiving problem fixed by #18648

mpfz0r commented 7 months ago

archiving problem fixed by #18648

it is not. this fix just allowed multithreaded archiving to work with data tiering enabled OS clusters.

This bug prevents it from accessing the necessary os infos to decide how many threads it should use.

janheise commented 7 months ago

@mpfz0r I specifically added a fix for the allocated processors problem. In my tests, the problematic os object failed later in Telemtry

mpfz0r commented 7 months ago

@janheise oh, sorry then. I got confused because the PR description doesn't mention that

mpfz0r commented 7 months ago

@janheise can we close that issue? or should we keep it open as a reminder when we switch back to the new client again?