search

Graylog2 / graylog2-server

Free and open log management
https://www.graylog.org
Other
7.35k stars 1.06k forks source link

DataNode: Decouple startup logic from Graylog server startup logic #18908

Open moesterheld opened 6 months ago

moesterheld commented 6 months ago

Data Node startup logic contains a lot of duplicated code from Graylog startup classes. While it makes sense that the startup mechanisms of Graylog should also be employed by data node, the duplication is a source for introducing errors when logic changes only on one side. Startup should be unified, e.g. by providing a common code base for startups, which could also be reused e.g. in forwarders.

bernd commented 6 months ago

@moesterheld Can you elaborate? We currently have copies of multiple server classes for the Data Node. We should remove the duplication and provide a shared code base for the startup code.

bernd commented 5 months ago

We met on the topic, and the issue description has also been updated. No further questions so far, thanks! :slightly_smiling_face: