Graylog2 / graylog2-server

Free and open log management
https://www.graylog.org
Other
7.33k stars 1.06k forks source link

Selected message not marked when viewing surrounding messages #19058

Open btr-wd opened 5 months ago

btr-wd commented 5 months ago

When I view the surrounding messages based on a message in the search, in earlier versions the selected message was marked with a green line at the left side. This is no longer the case although the query parameter highlightMessage=<guid> is set, I think since v5.2.4.

Expected Behavior

A list of messages surrounding the selected message in the selected time range should be shown and the selected message should be highlighted in some way.

Current Behavior

All the messages look the same.

Possible Solution

Draw a border around the selected message and a green vertical line on the left of it, like it used to be.

Steps to Reproduce (for bugs)

  1. Search messages with results.
  2. Use the "Show surrounding messages" feature.
  3. Look for the message the surrounding messages view was based on.

Context

Seeing the selected message immediatel would make it easier to spot it and to get an impression of the chain of events that might have lead to it.

drewmiranda-gl commented 2 days ago

This appears to also be related to the expanded message missing its left border as well.

Image

These left borders (highlighted, expanded) are present in Graylog 5.1 but not present in 5.2.

I THINK this is the applicable file? https://github.com/Graylog2/graylog2-server/blob/61686ecd108e5ef8e6c0a209e316dac49b4f0350/graylog2-web-interface/src/views/components/messagelist/MessageTableEntry.tsx#L60