Added test for LegacyDatanodeKeystoreProvider, removed CertService de… - Githubissues

Graylog2 / graylog2-server

Free and open log management

https://www.graylog.org

Other

7.22k stars 1.05k forks source link

Added test for LegacyDatanodeKeystoreProvider, removed CertService de… #19735

Closed todvora closed 4 days ago

todvora commented 1 week ago

Removed dependency to deprecated CertificateService, added unit tests.

/nocl

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.

todvora commented 4 days ago

@moesterheld Thanks! These classes are being removed in https://github.com/Graylog2/graylog2-server/pull/19747 anyway.