search

Graylog2 / graylog2-server

Free and open log management
https://www.graylog.org
Other
7.44k stars 1.07k forks source link

Font Awesome css is getting imported multiple times #7121

Closed linuspahl closed 3 years ago

linuspahl commented 4 years ago

Expected Behavior

The font awesome css should only get imported once. Because we are using icons everywhere, it should be okay to import it once globally.

Current Behavior

Currently the font awesome css is getting imported (in my case) eight times. The behavior is maybe related to the plugin system.

Possible Solution

One possible solution could be adding the styles to the the vendor bundle by creating a shared asset folder for the font dependencies.

Steps to Reproduce (for bugs)

You can easily test this by searching for "Font Awesome" in the page <head>.

Your Environment

Gaya commented 3 years ago

Think it doesn't happen anymore. Can only find one style tag with font awesome CSS.

Can we close this @linuspahl ?

linuspahl commented 3 years ago

@Gaya You are right, this is no longer a problem.

Gaya commented 3 years ago

@linuspahl 🙌