search

GreatDevelopers / Certificate

Web-based Certificate generation system
MIT License
20 stars 35 forks source link

Certificate Without Image #34

Closed amisha2016 closed 7 years ago

amisha2016 commented 7 years ago

With this PR we will be able to create certificate for both manual as well as CSV section.

amisha2016 commented 7 years ago

@vigasdeep You mean to say I should commit for 50 lines of code and so on and then send single PR.

vigasdeep commented 7 years ago

No, I meant, Small commits. You can send multiple commits in a PR.

Small commits help others understand whats going on in smaller changes otherwise one do not get general idea by reading 200-300 LOC.

On 09-Oct-2017 12:07 AM, "Amisha Budhiraja" notifications@github.com wrote:

@vigasdeep https://github.com/vigasdeep You mean to say I should commit for 50 lines of code and so on and then send single PR.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/GreatDevelopers/Certificate/pull/34#issuecomment-335028385, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCzTRwLMYBbC9L8c-jdX3-0MBUDHX4dks5sqRZWgaJpZM4PwX9P .