GreatOdds / Stairs3D

Addon for creating procedural stairs in Godot Engine
MIT License
29 stars 1 forks source link

Blue lines when used with Decals #3

Closed GonnaFlyMethod closed 1 month ago

GonnaFlyMethod commented 1 month ago

Hey, I'm using this version of the asset. When the stairs are behind the decals there are some weird blue lines:

image Scene's set up: image

It's super visible when stairs doesn't have any materials assigned or there's a bright material. When I remove decals, the lines disappear. It only happens with the CSG stairs. Godot engine version: v4.2

GreatOdds commented 1 month ago

Could you send an example project where it happens?

The blue line looks similar to the gizmo for a decal. Does it disappear if you turn of decal gizmos in View > Gizmos?

GreatOdds commented 1 month ago

Do you have Debug > Visibile Collision Shapes turned on? It might be the collision shape that you are seeing.

image

GonnaFlyMethod commented 1 month ago

Hey, thanks for your answers, I would check this out today answers let you know the result, if the lines still will be there I would assemble the project for you

On Fri, Sep 27, 2024, 7:16 AM GreatOdds @.***> wrote:

Do you have Debug > Visibile Collision Shapes turned on? It might be the collision shape that you are seeing.

image.png (view on web) https://github.com/user-attachments/assets/69e4824f-a01b-4f60-a27c-208b3d3113a5

— Reply to this email directly, view it on GitHub https://github.com/GreatOdds/Stairs3D/issues/3#issuecomment-2378417507, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQFUW5B6KP6KKPMI2WNINTZYTSZTAVCNFSM6AAAAABO5MRHGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGQYTONJQG4 . You are receiving this because you authored the thread.Message ID: @.***>

GonnaFlyMethod commented 1 month ago

Tried to turn off gizmos in View > Gizmos - still have these blue lines, Debug > Visible Collision Shapes is disabled. It's interesting, but my friends do not encounter such thing with stairs in their editors. But I do see the lines both in the editor and release build.

Let me prepare for you a godot project with decals and stairs set up

GonnaFlyMethod commented 1 month ago

Also, when the bottom of the stairs is generated I do not see those blue lines, only when placing decals under the stairs without generated bottom. Also, if the camera is under the stairs without bottom, and the decals is on the other side of the stairs, there are still those blue lines: image

Red color means that I do not generate bottom for the stairs, and the camera is placed in the volume that is kind of reserved for bottom of the stairs (this is the second case where I see the blue lines): image

GonnaFlyMethod commented 1 month ago

Hi, here's the project with reproduced issue. Godot version v4.2

I've spotted that it has something to do with lighting. The problem showed itself in runtime, when I've added WorldEnvironment to the nodes' hierarchy.

image image

GreatOdds commented 1 month ago

I did some tests. It seems the lines show up for both the Stairs3D and the normal MeshInstance3D.

You can see the lines on the sphere mesh. OnSphere

This might be a bug with the Decals node and not related to Stairs3D. Could you also try the MeshInstance3D on your device?

GreatOdds commented 1 month ago

godotengine/godot#62073

Looks like there's already an issue for this. Do you also have an AMD GPU?

GonnaFlyMethod commented 1 month ago

Hello, thanks for investigation, yeah, I have AMD based graphics hardware, issue still persists on Godot 4.2, then. Do you have any ideas for workarounds?

GonnaFlyMethod commented 1 month ago

By the way, 2 of my friends that tested the scene both in the editor and in rutime, did not encounter such issues, they are using NVIDIA

GonnaFlyMethod commented 1 month ago

I've tested decals with other meshes and here are results: 1. Spheres: I have weird lines with sphere mesh similar to your screenshots: image

2. Capsules: Similar glitch with capsule mesh, but the artefacts appear at the top part of the capsule: https://github.com/user-attachments/assets/d7d20866-1632-4608-ba4d-80c9949a9a75

3. Cylinders: Similar glitch: image

4. Prisms: Prisms are mostly ok, at least on my machine: image

5. Box meshes: Box meshes are ok as well: image

6. Plane mesh: OK: image

7. Quad mesh OK: image

8. Torus mesh: Not ok, the wireframe appears because of the decal node: image

9. Text mesh Not ok, the lines of wireframe appear: image

10. Tube trail mesh Not ok, the wireframe lines appear: image

11.Ribbon trail mesh Not ok, lines still appear: image

GreatOdds commented 1 month ago

From what I read from the godot issue thread, it seems to be most noticeable on meshs with a high metallic and low roughness material.

As for workarounds, you could try the mobile renderer instead of forward+ (top right of the editor).