V2.0.0 - initial issues (consolidated from Discord)

TSKimball commented 4 years ago

Description

Base information

Minecraft version: 1.12.2
Minecraft Forge version: 14.23.5.2838
TolkienCraft III version: 2.0.0

Issues

From the Discord discussions this week:

1 Stable vendor in housing Dims does not have an actual 1.12 horse in the 'Prized Steed' lasso.

Fix (from coehlrich): File - world/customnpcs/markets/stable.json, change EntityHorse to minecraft:horse (line 252).

2 Some runs of the world do not (re)spawn actual horses in the stable pens. This is possibly due to my building the instance manually in MultiMC.

Workaround for now is to cheat in spawn eggs as needed. Suggestion was made to also sell these spawn eggs for 10 copper; they should be cheap as some will spawn as colts.

3 Builders for the housing are not responding to the keys that are purchased.

Turns out they are no longer sync'd to the schematics files, which will need to be re-done similar to the quest re-working. So will be a longer-term fix. Temporary workaround - break any iron doors in Creative/Admin and replace them with wooden ones. Normal vanilla claim tracking (signs etc) can be employed as needed.

4 Various other items. -> Version on start page needs updating. -> Butcher is selling a 'blank' spawn egg, probably replace that one with Rabbit (and review all of those spawn eggs to confirm they're correct). Also consider adding a Llama spawn egg. -> Starting Tinker's Broadsword has no metadata, so not doing the expected damage for an iron sword. Workaround for now is to cheat in a 'normal' all-iron sword to replace it.

GreatOrator commented 4 years ago

Going to add https://github.com/GreatOrator/TolkienCraft-3-Return-to-Middle-earth/issues/83 as part of this to consolidate all of the known issues with the pack release

Teraphina commented 4 years ago

Rivendal Milestone tps you under the world.

GreatOrator commented 4 years ago

Unchecked items still need to be addressed

[x] Keys lost their sync to lockable chests - The named one from bosses have all been fixed. No markers for all the randomly placed loots ones, so those will get fixed as I find them or have them reported.
[x] TolkienTweaks coins are being seen as incorrect denominations by CustomNPC - Fixed in TolkienTweaks, the oredictionary settings were causing this
[x] Prized Steed in Player Housing stablemaster no longer spawns
[x] Pack version on main menu incorrect
[x] Starting broadsword lost NBT - Updated Starting gear list
[x] Location of player housing areas not clear when doing the starting quests - Added trigger to add waypoints for journeymap for all three areas.
[x] New Merchant to sell mob skulls
[x] Milestones have lost their coordinates and are TPing players into the void
[x] Player housing blocks lost their schematics
[x] Possible junk seller to sell vanilla mob drops
[ ] Possible boss in "spider" area in Moria

Chapter 1

[x] Castien master smith in Rivendel has no items for sale
[x] Hokland respawns almost immediately after killing.

Chapter 2

[x] After defeating the Goblin boss it completed with Gloin and it sounds more like an auto-complete - re-worded the dialog
[x] Gloin also doesn't have quest marks above his head like the previous quest givers. - Added marks, though most of the NPCs at this point and beyond won;t have marks because of the limit in number allowed
[x] Map set to peaceful and mob spawning off
[x] The cornerstone at Mt Gundabad: if you change it to not stop on interact it won't move when someone interacts with it :)
[x] Last Refuge II completion dialogue sounds like it should be an auto-complete - Reworded
[x] Some mobs/chests still giving out TolkienTweaks coins instead of the new TT Mobs coins - Fixed the ones I found, mostly in the dungeon key chests

Chapter 3

[x] Chapter start screen not firing - Fixed the options for the quest to trigger
[x] Ranger Camp: Pelleas speaks to me about a shield I know nothing about. Something isn't gated correctly. I haven't started talking to the rangers yet. - Missed the availability for the second dialog of his*
[x] Ranger Camp seems a bit bare too unless you are planning to add Ranger mobs :P - Added humans there (was always my intention)
[x] Against His Leader cannot be started because Manwyn greets you with the wrong dialogue. The one he has active is after defeating the stone statues. - Availability missing from dialog
[x] Challenging the Watcher: I passed through the statues but no entity showed up. - *Fixed, quest not auto claiming
[x] Name mismatch for Spirit of the Watcher quest

Chapter 4

[x] Chapter four splash did not come up
[x] Into the Dungeon: The wall near the ambush did not get removed.
[x] Bruabiuth in Khedgroick's Tomb respawns almost immediately.
[x] Layles would stop at each ranger, walk back the way she came, then teleport far ahead in the dungeon. - *Can't fix, has to do with tic rates. Locally it worked fine when I tested but have had issues with scenes acting like that sadly.
[x] Layles never was at the final door but it opened and then she teleported inside to die. - *Can't fix, has to do with tic rates. Locally it worked fine when I tested but have had issues with scenes acting like that sadly.

Chapter 5

[x] Chapter 5 didn't flash across the screen.
[x] I did not get Rekindling Hope IV after getting the shield back from Pelleas
[x] stuck on Castien. I gave him the sword to fix, but he is stuck on Reforging the Sword VIII dialogue. I looked at the cnpc quest log and it says I need to read the dialogue Rivendell-Reforging but doesn't say who I am to talk to.
[x] Close Layles' tent when she is dead to players. It breaks immersion to see her back at the camp

Chapter 6

[x] Bagamul in the Old Forest respawns too quickly
[x] Guruuk in the Lone Lands respawns too quickly
[x] Surbag in West Moria also respawns too quickly
[x] Constable Underhill is so tiny that a quest mark above her head would help us find her
[x] Cromhes' Request -Combe: you should tell players in the quest book to visit the constable. I went straight to the evil idol and that wasn't suppose to happen.The same with the other two requests.
[x] the blocks of gold, diamond, iron in West Moria to be real? Maybe make them out of chisel and bits? for the sake of servers?
[x] quest book says to return to Thruden but we are suppose to return to Cromhes first. That is confusing.
[x] When completing Cromhes request, he does not tell you to go to Thurden. This is what he says: You have done the Free Peoples a great service. Thank you. - *For quest completion, yes. Once you speak to him again you get the dialogs for direction to thurdan
[x] Now Thurden will not talk to me. Dreulhara's Trail I dialog not attached to Cromhes.
[x] Hero of Middle Earth I: location block will not activate to find Main Tent

teagan75 commented 4 years ago

Chapter 3:

Challenging the Watcher: I passed throught the statues but no entity showed up. I am on a sp map with commands enabled.

teagan75 commented 4 years ago

Chapter 4

Bruabiuth in Khedgroick's Tomb respawns almost immediately.
Into the Dungeon: The wall near the ambush did not get removed.
Layles would stop at each ranger, walk back the way she came, then teleport far ahead in the dungeon.
Layles never was at the final door but it opened and then she teleported inside to die.

Chapter 5

Chapter 5 didn't flash across the screen.
I did not get Rekindling Hope IV after getting the shield back from Pelleas
I am stuck on Castien. I gave him the sword to fix, but he is stuck on Reforging the Sword VIII dialogue. I looked at the cnpc quest log and it says I need to read the dialogue Rivendell-Reforging but doesn't say who I am to talk to.

teagan75 commented 4 years ago

Suggestion: Maybe do to Layles' tent what you did for Cromhes? Close Layles' tent when she is dead to players. It breaks immersion to see her back at the camp :P

GreatOrator commented 4 years ago

Hiding comments not necessarily because they are resolved, but because I added to the checklist above to make it easier for me to keep track.

coehlrich commented 4 years ago

The Oil-covered key in the Forging Anew II in dialogue quest isn't given to the player. From what i could find it seems to be because the command run after the Forging Anew V dialogue tries to give the player the "customnpcs:npcKey2" which seems to have been removed and when looking at the quest book it requires the "tolkienmobs:item_oilykey" item

coehlrich commented 4 years ago

The repeat time key for better questing was changed so that it doesn't contain capitals and the 4 was changed to a 3 (easily fixable by removing all lines containing repeattime:3 then replacing all instances of repeatTime:4 with repeattime:3 and after doing some research it seems that this was caused by a change in vanilla minecraft since it now automatically converts resource locations to lowercase. After doing it from within the file some of my cooldowns got set to 36 hours and 0 seconds although after claiming the 0 second one it got set to 15 minutes). It also doesn't seem like better questing allows you to claim rewards from quests with no tasks (except for auto claim ones maybe?)

GreatOrator commented 4 years ago

I'll take a look at both of those when I get home later today. I did notice the issue with better questing and thought I had caught all of them, but easy enough to fix those and they can be included in a pack update whereas NPC quests would require a map update and I am trying to stick to monthly updates for that because of the size of the download.

GreatOrator commented 4 years ago

Alright, both fixed and will be in the next pack update.

Learius1220 commented 4 years ago

Eriador Housing Dimension has no night cycle and the large house at the back's block has an error message when using the key (and yet I made sure to use the right key, even bought a second time to make sure)

checco-01 commented 4 years ago

is there a way to reduce the nuber of npcs spawing? my pc is a bit a potato and in rivendale and bree it will freeze constantly

GreatOrator commented 4 years ago

that question should have been asked in a new issue or in my discord. But yes, the configs have a spawn rate you can adjust though it only affects my spawns

checco-01 commented 4 years ago

sorry next time i will post the issue in the right section,thanks for the answer

ghost commented 4 years ago

Crash whenever rendering chunk with corrupted nbt data near X:14495 Y:43 Z:9907

GreatOrator commented 4 years ago

Please submit your own issue including the actual crash report, what you gave does not help me find the reason for the crash.

davidj2121 commented 2 years ago

i saw it addressed in your list, but the modpack still seems to have the hang up with castien that does not allow progression through the forging quest in Ch.5. Which NPC offers the dialogue to unlock the next stage?

GreatOrator / TolkienCraft-3-Return-to-Middle-earth