search

Greater-London-Authority / ldn-viz-tools

https://greater-london-authority.github.io/ldn-viz-tools/
1 stars 0 forks source link

move chrome that goes around chart from shared/ to chartContainer/ #186

Closed jamesscottbrown closed 7 months ago

jamesscottbrown commented 7 months ago

What does this change?

The charts library includes a chartContainer component that adds chrome like a Title/SubTitle/Export buttons around a chart.

This PR moves the components used by this component from the shared/ directory to the chartContainer directory.

ChrisKnightLDN commented 7 months ago

What's the logic of this as the chart container is 'shared'? (asking for a friend)

jamesscottbrown commented 7 months ago

They are all used to render things outside the main chart area, and are currently used only by the chartContainer, so it makes sense to group them together.

In contrast, the rest of the contents of shared/ are to be used inside the plot area, within a LayerCake component.