search

Greater-London-Authority / ldn-viz-tools

https://greater-london-authority.github.io/ldn-viz-tools/
1 stars 0 forks source link

Toaster #218

Closed PaulioRandall closed 6 months ago

PaulioRandall commented 7 months ago

What does this change?

  1. Adds a Toaster component for rendering short lived toast messages.
  2. Adds a newToastMessage function for posting new toasts from anywhere in the app.

Why?

Needed toasts for error messaging in call for sites.

How is it tested?

  1. Within Call for Sites app.
  2. Storybook

How is it documented?

  1. Storybook
  2. Experimental story presenting the TypeScript types as defined in code
  3. Experimental README for reference when we figure out how we want to do API docs

Are light and dark themes considered?

Yes.

PaulioRandall commented 7 months ago

dataScatter.d.ts is a recurring source of lint failure.

PaulioRandall commented 7 months ago

dataScatter.d.ts is a recurring source of lint failure.

Reverted Prettier's formatting.

jamesscottbrown commented 7 months ago

Preview: https://dev.ldn-gis.co.uk/storybook-toaster/?path=/docs/ui-toaster--documentation

jamesscottbrown commented 7 months ago

LGTM