Greater-London-Authority / ldn-viz-tools

https://greater-london-authority.github.io/ldn-viz-tools/
1 stars 0 forks source link

Fix map controls divs interferring with map interactions #219

Closed PaulioRandall closed 7 months ago

PaulioRandall commented 7 months ago

What does this change?

Fixes map controls interfering with map interactions.

Why?

Map control areas preventing panning and drawing on the map. Mostly only noticable on smaller laptops, e.g. surface pro etc.

How?

Disabled all pointer events in map controls and enable only at a fine grained level, i.e. applied pointer events to buttons directly rather than their containing elements to avoid padded and margin space from causing problems too.

jamesscottbrown commented 7 months ago

This looks fine.

The linting Github Action seems to have got stuck: there is apparently a problem with Actions currently.

image https://www.githubstatus.com/

jamesscottbrown commented 7 months ago

LGTM