search

Greater-London-Authority / ldn-viz-tools

https://greater-london-authority.github.io/ldn-viz-tools/
1 stars 0 forks source link

Update Checkbox & CheckboxGroup with tooltips #296

Closed PaulioRandall closed 1 month ago

PaulioRandall commented 1 month ago

What does this change?

Adds tooltips to Checkbox and CheckboxGroup.

Why?

Required where extra information is long or essential.

How is it tested?

Storybook.

How is it documented?

Storybook.

Is it complete?

jamesscottbrown commented 1 month ago

This looks mostly good, but what is the purpose of setting id to the randomly generated value of selectAllId?

PaulioRandall commented 1 month ago

This looks mostly good, but what is the purpose of setting id to the randomly generated value of selectAllId?

To fix a warning about required id prop not being passed to <Checkbox>.