search

Greater-London-Authority / ldn-viz-tools

https://greater-london-authority.github.io/ldn-viz-tools/
1 stars 0 forks source link

Update tooltip with modal #304

Open PaulioRandall opened 1 month ago

PaulioRandall commented 1 month ago

What does this change?

Adds support for modals to tooltips.

Why?

To ensure long and essential information for layer toggles can be placed somewhere, e.g. Green Spaces layer in https://apps.london.gov.uk/wild-and-free/ requires showing license info and link to the London DataStore.

How is it tested?

Storybook

How is it documented?

Storybook

Is it complete?

jamesscottbrown commented 1 month ago

I need to look at this together with the SidebarHint component 1 tomorrow - both render either a tooltip or modal.

PaulioRandall commented 1 month ago

@jamesscottbrown ready for review.

ChrisKnightLDN commented 1 month ago

@jamesscottbrown when reviewing this - the sidebarHint has a todo against it to implement a popover - see meltUi popover - also implemented in hsds hub.

PaulioRandall commented 1 month ago

I need to look at this together with the SidebarHint component 1 tomorrow - both render either a tooltip or modal.

I've updated <SidebarHint> to use a <Tooltip> for its modal option. I realize this change will be further overridden by #346 so I avoided changing too much.