Minor UI fixes - Githubissues

Greavesy1899 / MafiaToolkit

Open source toolkit for Mafia games. (Mafia II, Mafia III, Mafia DE)

MIT License

123 stars 20 forks source link

Minor UI fixes #33

Closed nptr closed 3 years ago

nptr commented 3 years ago

As a start, some minor UI fixes:

Removed flickering of folder tree and file list with double buffering. The Win32 controls do support it but it isn't exposed to WinForms. Hence reflection and platform invoke..
Added missing localization entries for the xbin editor. Always with the English text as placeholder. A proper translation is needed.

Greavesy1899 commented 3 years ago

Nice changes to Game Explorer. Do you advise adding these UI fixes to other editors with long containers (such as map editor) or was it just an issue with the Game Explorer?

nptr commented 3 years ago

Yes, especially tree views and list views in resizable windows benefit greatly. I can make the fix for all of them if you'd like. Can I open the map editor for M1DE as well? I haven't found it yet.

Greavesy1899 commented 3 years ago

Sadly no. :(

It's only for Mafia II. You can open it by double clicking a "FrameResource_X.fr" file. In the future I hope to change this with a much more visible approach such as "Open Map Editor", then you can select which SDS to load.

nptr commented 3 years ago

I applied the changes to the rest of the tree views. Can't check if it had a visible effect since I only have M1DE for testing. The XBIN editor did not benefit at least. Your decision whether/what to merge.

Greavesy1899 commented 3 years ago

There is actually another significant list here - Forms/Docking/DockSceneTree.Designer.cs

This uses a tree view for all loaded objects. After that one has been double buffered, I'll merge it.

nptr commented 3 years ago

Since I'm not really a fan of manually setting each control to double buffered, i went the inheritance way. Conveniently there is already your custom "MTreeView" which i extended. Analog to this, I added a double buffered "MListView". Please see my follow up PR . It's cleaner code and has a nicer git history. Thus I am closing this PR.