[Bug] Build Fail due to Invalid Version String

ObscenityIB commented 2 weeks ago

Description of the issue

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:01.63
Clearing NuGet HTTP cache: /home/obscenity/.local/share/NuGet/http-cache
Clearing NuGet global packages folder: /home/obscenity/.nuget/packages/
Clearing NuGet Temp cache: /tmp/NuGetScratchobscenity
Clearing NuGet plugins cache: /home/obscenity/.local/share/NuGet/plugin-cache
Local resources cleared.
  Determining projects to restore...
/home/obscenity/.cache/yay/ryujinx-git/src/dotnet/sdk/8.0.302/NuGet.targets(169,5): error : 'Canary-1.2.15' is not a valid version string. (Parameter 'value') [/home/obscenity/.cache/yay/ryujinx-git/src/Ryujinx/src/Ryujinx/Ryujinx.csproj]

Reproduction steps

Update AUR package ryujinx-git which now points to this repo.

Dotnet build mostly succeeds, however fails on an invalid version tag.

Log file

N/A

OS

Linux

Ryujinx version

Canary-1.2.15

Game version

No response

CPU

No response

GPU

No response

RAM

No response

List of applied mods

No response

Additional context?

No response

GreemDev commented 2 weeks ago

This is something the AUR is doing. The Canary version string is not passed to .NET. It compiles fine on my system, and in CI, which is linux.

Edit: Maybe it's going based off of tag version. That's the only one with a hyphen. In which case the AUR needs to do ryujinx-git and ryujinx-canary-git channels.

ObscenityIB commented 2 weeks ago

Yup, looks like it.

 _args="-c Release -r linux-x64 -p:Version=$(git describe --tags) -p:DebugType=embedded -p:ExtraDefineConstants=DISABLE_UPDATER%2CFORCE_EXTERNAL_BASE_DIR"

Maybe it expects tags to be semver compliant, which is rather hopeful.

GreemDev / Ryujinx