GreemDev / Ryujinx

Experimental Switch emulator written in C#
MIT License
5.3k stars 425 forks source link

Fixed game load #220

Closed sovervo closed 2 weeks ago

sovervo commented 2 weeks ago

I'm not sure how correct they are. What do you think?

github-actions[bot] commented 2 weeks ago

Download the artifacts for this pull request:

LotP1 commented 2 weeks ago

wow this took a while to trace back. apparently the case 2: was added as a quick fix over 6 years ago here https://github.com/GreemDev/Ryujinx/commit/c9f54aabfb7e5cffe0f384cada09a71c59298e03 does anyone know what the difference between IpcDuplicateSession and IpcDuplicateSessionEx is?

LotP1 commented 2 weeks ago

After reading up on years old commits, the Atmosphere sourcecode and switchbrew documentation i've come to the conclusion that the current behavior matches real hardware. I don't know why blocking the CloneCurrentObject call (the real name of IpcDuplicateSession) works, but this should not be used as the solution.

GreemDev commented 2 weeks ago

I'll have to agree with @LotP1 on this. That being said if you can get this game working without compromising hardware parity that would be welcomed.