Green-Party-of-Canada-Members / gpc-decidim

Decidim For the Green Party of Canada
https://wedecide.green.ca/
GNU Affero General Public License v3.0
1 stars 0 forks source link

Minor fixes #120

Closed paarals closed 10 months ago

paarals commented 10 months ago

Making sure Abstention buttons are clear, readable and follow design principle:

Preventing "Change my Vote" from triggering modal window:

Desired: Modal window triggered every time a vote/support is made, but not when "Change my vote" is pressed.

Specifying name of proposal in modal window:

Only if it's easy to do, you could add the proposal title to the modal window.

Making voting more visible to mobile clients:

When reading on mobile, participants will see the donate panel first and might not realize they have to scroll down further to see the voting panel. Let's promote the Voting panel to the top, to ensure that mobile clients see it first.

Removing Google crawling restriction:

We've decided to allow Google to index the site again.

Add language-specific GPC logo:

gpc_logo_web_green_fr

Verifying modal window compliance for the visually-impaired:

I don' t know if this is an issue of not, but just wanted to be clear about the North American standard for how visually-impaired readers expect to have modal windows marked: "Active popups should include an "aria-modal" attribute that equals to "true", and a "role" attribute that equals to "dialog", so screen-reader users know how to navigate within it."

BigSnicker commented 10 months ago

Added a fix.

BigSnicker commented 10 months ago

I haven't verified the ROBOTS text or the visually-impaired reading, but everything looks great. Closing the ticket.