Simple one-at-a-time amendment support

BigSnicker commented 10 months ago

Feature Behaviour:

As Green Party of Canada I want...

[x] Only one amendment can be "under evaluation" for each proposal. When the amendment is accepted or rejected, a new amendment can be created for the proposal
[x] The amendment must be against the text in the original language
[x] When there is an amendment, the user who wants to amend will see: 1) The amendment being evaluated 2)An explanation of why they cannot enter a new amendment 3) An explanation of how to be notified to see the latest news about the proposal

As a participant, I want

[x] Contextual message “This proposal was originally submitted in %LANGUAGE%. Please submit your amendment in %LANGUAGE% in order to simplify the amendment process. Your amendment will be translated to other languages immediately upon acceptance.”
[x] Contextual message “There is already an amendment for this proposal. Please contact the submitter and ask them to accept or reject the amendment or wait until it’s been accepted or rejected.”

Web Administration:

No changes to the Web Admin interface are anticipated. The feature can apply to all amendments.

Exporting

No changes to data exports are expected.

Cases to be tested:

[x] The machine-translation applies for the new text with amend? Yes! (be aware that version control is another story)

More context if applies:

Supporting the following cases would be ideal:

) A unilingual amendment to an Official Proposal (possibly, but not necessarily in the default language only) ) A unilingual amendment to a User Proposal, in the submitted language only

Potentially with the following behaviours:

Only a single active amendment per proposal. Attempts to submit a second amendment are met with "you must wait until a previously submitted amendment is accepted or rejected"
Rejection of amendment if submission is in an inappropriate language

Minor fixes

microstudi commented 8 months ago

Mockup proposal Screenshot from 2024-01-04 16-21-28

BigSnicker commented 8 months ago

That looks great.

BigSnicker commented 7 months ago

Found a possible bug....

BigSnicker commented 7 months ago

Also, this might not be a problem, but the co-author images seem very close together after an amendment is accepted:

This shows up in any proposal with multiple authors. Note that the additional spacing could be very small: https://staging.deploy.green.ca/processes/Policy2021/f/223/proposals/2591

BigSnicker commented 7 months ago

Another issue... can I confirm that we've taken out the "search for similar proposals" step in amendment submission? We're getting feedback that it is confusing.

UPDATE: This is closed, thanks to the 0.99 search similarity factor.

BigSnicker commented 7 months ago

Also.... we might want the default setting of the Type filter to be just "proposals", if possible, and for any change to be persistent across the session.

Example: https://staging.deploy.green.ca/processes/Policy2021/f/275/

BigSnicker commented 6 months ago

If possible, please set the default 'diffcomp' view to side-by-side.

microstudi commented 6 months ago

Another issue... can I confirm that we've taken out the "search for similar proposals" step in amendment submission? We're getting feedback that it is confusing.

this should work with the env PROPOSALS_SIMILARITY_THRESHOLD var set to 0.99 for instance

paarals commented 6 months ago

closed via #153

Green-Party-of-Canada-Members / gpc-decidim