Green-Software-Foundation / carbon-aware-sdk

Carbon-Aware SDK
https://carbon-aware-sdk.greensoftware.foundation/
MIT License
445 stars 93 forks source link

[terminology]: mean marginal vs. average carbon intensity #215

Closed buchananwp closed 10 months ago

buchananwp commented 1 year ago

Contact Details

wibuchan@microsoft.com

What happened?

It's not a bug, it's a terminology suggestion.

emissions/average-carbon-intensity

For this query, the carbon-aware-sdk returns a mean marginal carbon intensity

'average' carbon intensity is an actual data type provided by WattTime and ElectricityMap. Marginal is a different type. Can we be consistent in our terminology?

client

WebAPI (Default)

Relevant log output

n/a

Code of Conduct

vaughanknight commented 1 year ago

Thanks Will! This is something we're going to be looking at moving forward also (terminology).

buchananwp commented 1 year ago

Thanks, Vaughan. Please pull Henry and I in when you’re ready for our review.

On Tue, Dec 13, 2022 at 7:49 PM Vaughan Knight @.***> wrote:

Thanks Will! This is something we're going to be looking at moving forward also (terminology).

— Reply to this email directly, view it on GitHub https://github.com/Green-Software-Foundation/carbon-aware-sdk/issues/215#issuecomment-1350231856, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEFHEUTSCA3NGBZH7JB36LWNERSHANCNFSM6AAAAAAS5IODZM . You are receiving this because you authored the thread.Message ID: @.*** com>

--

Best, Will

github-actions[bot] commented 1 year ago

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

buchananwp commented 1 year ago

Is this still in-progress?

github-actions[bot] commented 11 months ago

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

github-actions[bot] commented 10 months ago

This issue has not had any activity for too long. If you believe this issue has been closed in error, please contact an administrator to re-open, or if absolutly relevant and necessary, create a new issue referencing this one.