Green-Software-Foundation / if

Impact Framework
https://if.greensoftware.foundation/
MIT License
137 stars 38 forks source link

πŸ‘πŸΌ Set up CI/CD to trigger automated tests for PRs #621

Closed jmcook1186 closed 1 day ago

jmcook1186 commented 2 months ago

Sub of: #629 -> #650

What Set up CI/CD to trigger automated tests that must pass for a PR to be mergeable

Why As a core developer I want to quickly see whether proposed changes pass our tests. This will speed up the review process and make us more confident int he changes we are merging in.

Context We are designing new automated tests to ensure the integrity of the IF source code. We want to make this part of the CI/CD process so all PRs are held to the same standards before being merged, but without adding more work for the reviewer. CI/CD is the solution to this problem.

Prerequisites

SoW

Acceptance criteria

GIVEN a user is developing against IF AND IF has a folder called manifests full of manifest test files AND all of the manifest files are passing. WHEN the user creates a PR THEN a GitHub action runs which runs if-check --folder /path/to/manifests AND the PR is marked as passing this check.

GIVEN a user is developing against IF AND IF has a folder called manifests full of manifest test files AND one of the manifest files is failing. WHEN the user creates a PR THEN a GitHub action runs which runs if-check --folder /path/to/manifests AND the PR is marked as failing this check. AND the PR has a link the developer can click to find out which manifest is failing

jawache commented 2 months ago

@jmcook1186 specifically this issue is related to the creation of both the manifest files folder (#615) and the if verify tool (#638), it's dependent on both of them being completed first.

Acceptance Criteria

With the issue updated to the new format and the above acceptance criteria you can mark this issue as πŸ‘πŸ½ from me.

jmcook1186 commented 2 months ago

ok @jawache updated, awaiting your approval

jawache commented 2 months ago

Done, so we're on the same page, this particular issue needs refinement by the dev to list out the work items in SoW

zanete commented 1 week ago

some investigation is needed to link the manifest files to the GH action