search

Green-Software-Foundation / if

Impact Framework
https://if.greensoftware.foundation/
MIT License
137 stars 38 forks source link

Errors in cloud-metadata plugin azure-instances dataset #876

Open adamhafiz427 opened 3 days ago

adamhafiz427 commented 3 days ago

Description of the Error

There are errors in some of the instance names the azure-instances dataset of the cloud-metadata plugin. Footnote markers in official Microsoft Azure documentations are mistakenly included in the names.

image

Expected Behaviour

Footnote markers should not be in the instance name, "Standard_E64ads_v52" should be "Standard_E64ads_v5"

Actual Behaviour

For example, "Standard_E64ads_v5" is written as "Standard_E64ads_v52" in the dataset, leading to errors when using the cloud-metadata plugin.

Steps to Reproduce

Use certain instance names as input for the cloud-metadata plugin in the manifest

Manifest File That Generated the Error

Any manifest with the following input: cloud/instance-type: Standard_E64ads_v5

I've created a PR fixing the discrepancies in the if-data repository here: https://github.com/Green-Software-Foundation/if-data/pull/1

jmcook1186 commented 3 days ago

Hi - thanks a lot for catching this!