search

Green-Software-Foundation / sci

A specification that describes how to calculate a carbon intensity for software applications.
Other
263 stars 54 forks source link

[Consistency Review] Removed repeated verbiage in Quantification method section #201

Closed srini1978 closed 2 years ago

srini1978 commented 2 years ago

Removed the line from Quantification method that was redundant, Also it spoke about a "third" step when the first and second steps are not discussed in this section.

jawache commented 2 years ago

Oh the steps are mentioned in the previous sections @srini1978 :)

First step mentioned in https://github.com/Green-Software-Foundation/software_carbon_intensity/blob/dev/Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md#software-boundary

The second step mentioned in https://github.com/Green-Software-Foundation/software_carbon_intensity/blob/dev/Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md#functional-unit-r

If we are keeping the others it makes sense to keep this one, perhaps it needs rewording to work as the first line?

jawache commented 2 years ago

Actually re-reading it, it does work as the first line. Would that make it match the others better @srini1978 ?

srini1978 commented 2 years ago

Actually re-reading it, it does work as the first line. Would that make it match the others better @srini1978 ?

Agree. I have made the changes and moved it to the first line. It makes perfect reading sense now @jawache @atg-abhishek Please take a look

Henry-WattTime commented 2 years ago

Approved by working group