search

Green-Software-Foundation / sci

A specification that describes how to calculate a carbon intensity for software applications.
Other
263 stars 54 forks source link

Fix broken link in README.md #374

Closed criscola closed 2 weeks ago

mrchrisadams commented 2 weeks ago

hi @seanmcilroy29 , @jawache I just tripped over this too, and was about to make the same PR, as right now following the links to the spec on the front page of the repo results in arriving at broken links.

Would it be possible to either close this PR, or make the necessarty changes to the main branch?

Here's what I see:

Screenshot 2024-09-13 at 11 33 10

And when I follow, the link to see the standard on github, I see this:

Screenshot 2024-09-13 at 11 34 23

This isn't a great first experience for people coming to the spec, and it looks like an easy fix.

These links appear to be fixed in the dev branch, but the main branch, that most people would link to has the issue, and I think they should be linking to the following links as this PR suggests

https://github.com/Green-Software-Foundation/sci/blob/main/SPEC.md https://github.com/Green-Software-Foundation/sci/blob/devSPEC.md

Linking to the 'live' site off of github.

Also, would you also consider linking to the compiled version of the site? It's useful to know it exists:

https://sci.greensoftware.foundation/

seanmcilroy29 commented 2 weeks ago

@criscola - Thanks for pointing this out; I've applied the updates via another PR