search

GreenBankObservatory / dysh

https://dysh.readthedocs.io
Other
9 stars 3 forks source link

ReadTheDocs raises new warnings #338

Open astrofle opened 1 month ago

astrofle commented 1 month ago

Describe the bug There are some warnings that only appear in the ReadTheDocs build, for example in the metadata notebook on the baseline correction with the unmodified metadata (this section) there is the following:

/home/docs/checkouts/readthedocs.org/user_builds/dysh/envs/cat-docs-devel/lib/python3.9/site-packages/astropy/units/core.py:2045: ResourceWarning: unclosed <ssl.SSLSocket fd=53, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('172.17.0.2', 41644), raddr=('192.33.116.7', 443)>
  if hasattr(s, "_get_physical_type_id"):

which is not on the "plain" notebook.

How to Reproduce Look at : https://dysh.readthedocs.io/en/cat-docs-devel/examples/metadata_management.html#metadata-inspection from PR #331.

Environment ReadTheDocs

astrofle commented 2 weeks ago

I saw the same error locally. It seems this comes from the from_url function? (just guessing because it mentions addresses).