Open vcatlett opened 1 month ago
Adding multifile=False
to the sdfits.write()
call fixed the issue with the notebook tests. See https://github.com/GreenBankObservatory/dysh/actions/runs/10253959223
However, this may still be a bug because this should already be the default behavior.
Describe the bug On
macos-latest
, the following line innotebooks/examples/dataIO.ipynb
does not write the expected output:sdfits.write(output_dir / "mydata.fits", plnum=1, ifnum=[0,2], intnum=np.arange(100), overwrite=True)
The following cell expects to find
notebooks/examples/output/mydata.fits
:sdfits2 = GBTFITSLoad(output_dir / "mydata.fits")
This works fine on
ubuntu-latest
andwindows-latest
. However, onmacos-latest
, we do not findnotebooks/examples/output/mydata.fits
. Instead, we findnotebooks/examples/output/mydata{0,1,2,3}.fits
.How to Reproduce See https://github.com/GreenBankObservatory/dysh/actions/runs/10252663222 On line 191 of the "Test with pytest" section of the
tests (macos-latest, 3.9)
, you can see via a debugging print statement that the contents ofnotebooks/examples/output/
are...3 OUTPUTS: ['mydata1.fits', 'testwrite.ipac', 'scanblock.fits', 'mydata0.fits', 'testwrite.ecsv', 'testwrite.fits', '.gitkeep', 'testwrite.commented_header', 'testwrite.basic', 'baselined_removed.png', 'testwrite.mrt', 'testwrite.votable', 'mydata3.fits', 'testwrite.fixed_width', 'mydata2.fits']