Support for python 3.8 - Githubissues

GreenBuildingRegistry / usaddress-scourgify

Clean US addresses following USPS pub 28 and RESO guidelines

MIT License

206 stars 47 forks source link

Support for python 3.8 #13

Closed bmckalla closed 4 years ago

bmckalla commented 4 years ago

Hi @fablet!

I noticed some issues with python 3.8 installations that can be solved by limiting the typing install as it isn't required in python 3.5 or later, since it's part of the standard python lib.

I tested with tox and it seems to be all set 👍

~~Although, I did notice you have a similar requirement in yaml-config, would you like me to pr there as well?~~

I went ahead and made the same pr in yaml-config

bmckalla commented 4 years ago

@fablet No problem, hope it was a good one 👍