GreenComfyTea / MHR-Overlay

Monster Hunter Rise Mod - Overlay mod that exposes internal game data about monsters, creatures, players, damage, buffs and debuffs.
https://nexusmods.com/monsterhunterrise/mods/50
MIT License
78 stars 25 forks source link

Reframework doesn't load when mod is placed in the MHR directory #67

Open cparker24 opened 1 year ago

cparker24 commented 1 year ago

Game simply freezes during loading while Reframework is initializing. Will launch with just Reframework and ReframeworkD2D. Attached the log. No crash file since it has to be killed externally since its just stuck. image re2_framework_log.txt

GreenComfyTea commented 1 year ago

(1) REFramework is detecting incorrect OS version. Getting 6.1.7600 instead of expected 10.0.22621. Kinda weird.

image

(2) The mod indeed doesn't load, but it's not the reason why the game crashes. REFramework simply does nothing with the mod, when it should read the mod code and either: 1) run it correctly and produce expected log output; or 2) show and print an error if it can't run the code.

Yours:

image

Expected:

image

After the mod load attempt REFramework continues the initialization normally, without any errors, until the end of file. Suspending threads here is expected, thou the end of log file is not. It is supposed to resume the threads right after suspension.

Yours:

image

Expected:

image

Right now I believe REFramework's Lua Scripting System is failing. Try loading the game with another mod to confirm the theory. This one, in particular (because I know that it has log output).

cparker24 commented 1 year ago

re2_framework_log.txt Interestingly enough it ran without issue and showed as loaded in the ReFramework menu.

GreenComfyTea commented 1 year ago

Even though it didn't lead to a crash, REFramework actually didn't finish loading VIP Dango Ticket mod either.

(The json error is normal since config file is missing on the first launch and is generated later automatically).

Please, check if /MonsterHunterRise/reframework/data/VIP_Dango_Ticket_Config.json was generated. If it wasn't generated, check that the game folder and mod files are not read-only. I have a suspicion that it might permission-related due to the fact that it's all located inside C://Program Files.

Yours:

image

Expected:

image

cparker24 commented 1 year ago

It was generated. I'd tried running MHR as administrator and that didn't fix anything when I was trying to set things up VIP_Dango_Ticket_Config.json

GreenComfyTea commented 1 year ago

Ok, I am out of ideas.

Download and install Nightly REFramework one last time, then zip /MonsterHunterRise/reframework/ folder and send it to me.

cparker24 commented 1 year ago

here nightlybuildtest.zip

GreenComfyTea commented 1 year ago

I meant to ask to send me reframework folder with Direct2D and the mod installed...

cparker24 commented 1 year ago

Whoops sorry reframework.zip

GreenComfyTea commented 1 year ago

I am absolutely clueless why the issue can be happening. Everything seems to be fine. The only things that I can think of at this point is win11. The fact that REFramework can't detect the correct OS version is suspicion but doesn't explain anything. Win11 is still in development and devs are making quite a lot of bug there, so it might be one of them. Or maybe it's because of virtualization/hypervisor? I legit don't know.

I am sorry that I couldn't help, and thank you for spending your time on testing. As an alternative you can try using HunterPie. It mostly has the same functionality as my mod.

cparker24 commented 1 year ago

Well that mod works so it's all good. Thanks so much for trying to work through this with me.