GreenComfyTea / MHW-Better-Matchmaking

Monster Hunter: World Mod - Disables Steam Region Lock, increases Max Search Result Count, provides Improved Search Filters.
https://nexusmods.com/monsterhunterworld/mods/7263
MIT License
9 stars 2 forks source link

Improve Translation #5

Closed Narugakuruga closed 4 months ago

Narugakuruga commented 4 months ago

Improve Translation for both variants of Chinese: Text strings were dumped from in-game localization. Convert the verbal difference between regions, so it won't confuse people

GreenComfyTea commented 4 months ago

Good call. Haven't even notice Traditional Chinese didn't use in-game values.

I want to ask to clarify some chances or make new ones before merging (those are just some changes that I was able to quickly visually distinguish, I don't know Chinese): 1) In Traditional Chinese Level1 and other level string in-game seem to have a whitespace in between: Level1 = Lv 1:

image

image

2) In Simplified Chinese same thing: but its fully translated in-game instead of just Lv1:

image

3) In both Chinese localizations MasterRank1Star and other star strings have the star and the number swapped in-game: MasterRank1Star = 大师⭐1. Those are currently not used in the mod, but I will use them when I add full unicode support.

image

image

4) In Traditional Chinese it seems that None was correct initially? In Simplified it is different too.

image

image

image

5) In both localizations Language string is different:

image

image

6) In Traditional Chinese those are different:

image

image

image

image

image

GreenComfyTea commented 4 months ago

In Simplified Chinese:

  1. Frostfang Barioth is different:

image

  1. All expedition objective are different:

image

  1. Region Level seems to have a whitespace in the middle?

image

  1. Languages are different:

image

Narugakuruga commented 4 months ago

I have received this feedback and some stuff are relatively trivial. I am taking a look into every aspect later

Narugakuruga commented 4 months ago

Good call. Haven't even notice Traditional Chinese didn't use in-game values.

I want to ask to clarify some chances or make new ones before merging (those are just some changes that I was able to quickly visually distinguish, I don't know Chinese):

  1. In Traditional Chinese Level1 and other level string in-game seem to have a whitespace in between: Level1 = Lv 1:

image

image

  1. In Simplified Chinese same thing: but its fully translated in-game instead of just Lv1:

image

  1. In both Chinese localizations MasterRank1Star and other star strings have the star and the number swapped in-game: MasterRank1Star = 大师⭐1. Those are currently not used in the mod, but I will use them when I add full unicode support.

image

image

  1. In Traditional Chinese it seems that None was correct initially? In Simplified it is different too.

image

image

image

  1. In both localizations Language string is different:

image

image

  1. In Traditional Chinese those are different:

image

image

image

image

image

1.White space were added.

2.Lv is commonly used in China so it would be comprehensible.

  1. I think it might be an inconsistency in original text.

  2. "None" in UI are equivalent of gathering quest. I found general type only consist of gathering quest and small monster quest? Clutch claw tutorial quest is single player only.

"No preference" means "empty setting" 未設定/未設置. I have get it done already.

  1. Fixed

  2. Fixed

Narugakuruga commented 4 months ago

In Simplified Chinese:

  1. Frostfang Barioth is different:

image

  1. All expedition objective are different:

image

  1. Region Level seems to have a whitespace in the middle?

image

  1. Languages are different:

image

  1. It's merely a font difference.
  2. Fixed
  3. I think this is a format issue in original text.
  4. I chose different term while meaning are the same
GreenComfyTea commented 4 months ago

2.Lv is commonly used in China so it would be comprehensible.

  1. I chose different term while meaning are the same.

I would like to keep it 1 to 1 match with the in-game text. There might be non-natives who is trying to play it in Chinese but don't know it well (students?), but more important dyslexic people will have hard time visually cross-referencing the text if it's different (including me).

"None" in UI are equivalent of gathering quest.

That is true only for quests. For sessions None will behave as No preference and search for all sessions with any type.

image

I found general type only consist of gathering quest and small monster quest? Clutch claw tutorial quest is single player only.

In-game quest filter for target doesn't even contain None and doesn't allow searching for gathering quests. I had to add it myself because my mod inverts filtering logic and if someone were to use the mod's filter, the game would still return gathering quests all the time, which is not a desire behavior. I utilized the existing None string because it seems fitting in English (since the filter is Target and you don't have any monster targets on gathering quests).

If you think that it doesn't really fit in Chinese (or even in English itself), I can add a separate string entry for quest target filter. Separate None or Gathering, if you wish.

Narugakuruga commented 4 months ago

I have done all the fix. Would be nice of you to merge now😀

Narugakuruga commented 4 months ago

The none and gathering could be seperate I think. Sometimes I aim for egg quest too, just for fun haha

GreenComfyTea commented 4 months ago

I remembered why I didn't make Gathering string. It's because target id = 0 which currently is None returns not just gathering quests, but also expeditions. So I won't make separate Gathering string, sorry.

GreenComfyTea commented 3 months ago

I am about to add custom font support. I haven't pushed any changes yet but you can start thinking what font you want your translation to have.