GreenDelta / olca-app

Source code of openLCA
openlca.org
Mozilla Public License 2.0
191 stars 41 forks source link

imported jsonld files that contain "tags" properties and are imported lose the tags when later exported #221

Closed xtitter closed 2 years ago

xtitter commented 2 years ago

The "tags" property is specified in the CategorizedEntity in the ocla schema. While it appears that the OpenLca application has no interface to show tags, it won't even persist them across and import and export cycle.

msrocka commented 2 years ago

Tags were added in openLCA 1.11. They can be added and removed in the respective data set editors:

image

In openLCA 2, there is even an experimantal result view to group result contributions by tags:

image

xtitter commented 2 years ago

That is great. Thanks.

My planned use of the tags will be for tools external to the openLca application. To keep things isolated, I expect I'll use key:value pairs for each tag, with some sort of special character delimiter and a specific key that the external tool looks for. Unfortunately, this is going to be somewhat clunky for the result grouping view that you've shared above.

I wonder if this is reasonable functionality to add to the ocla-schema and/or the openLca application? It would allow for tagging that supports orthogonal purposes: i.e., the results view could group based on tag values with a specific key, etc.

msrocka commented 2 years ago

Yes, this would be a very useful addition and we indeed plan to support such key-value pairs in one of the next versions. We wouldn't use the tags field for this but add some other field; not sure about the name yet, maybe just properties. Also, we plan to support not only string values but also structured types (basically JSON), e.g. in olca-schema it could look like this:

{
  "@type": "Process",
  "@id": "123...",
  // ...
  "properties": {
    "the": {
      "result": "of it",
      "is": [42]
    }
  }
}

This should be editable in the user interface of openLCA then; maybe something like the about:config page in Firefox as an additional tab in the data set editors which could be enabled via the application settings:

image

msrocka commented 2 years ago

Closing this because there is a separate issue now: https://github.com/GreenDelta/olca-app/issues/232