search

GreenDelta / olca-simapro-csv

Mozilla Public License 2.0
0 stars 1 forks source link

Add QuantityBlockTest #2

Closed Miguel-g-c closed 3 years ago

Miguel-g-c commented 3 years ago

Hi Michael, just checking it out again and in process.csv we have:

Quantities
Mass;Yes
Energy;Yes
Length;Yes

So those Yes mean that .hasDimension() should be true instead of false, shouldn't it?

msrocka commented 3 years ago

Yes, this was wrong. The idea is that the tests find such things...

Miguel-g-c commented 3 years ago

Ok, I'll modify it in the next PR

msrocka commented 3 years ago

it is already fixed