GreenFlag31 / modal-library

ngx-modal-ease is a versatile Angular library providing a lightweight, simple, and performant modal.
https://greenflag31.github.io/modal-library/
14 stars 2 forks source link

Stacked modal reopens on close #1

Closed jagabs closed 7 months ago

jagabs commented 7 months ago

Hey man nice work! I just have one problem, when i stacked like 4-5 modals and close it fast, sometimes it reopens do you whats happening? been trying to debug it.

GreenFlag31 commented 7 months ago

Hi Jagabs,

Thanks you for your message. I try to reproduce the issue.

To close it fast, are you using the escape key or clicking outside (click on the overlay), or press on a button in the content of the modal that triggers the modalService to close? Are you using animations?

Please make sure that:

Meanwhile, I found a bug that cause the modal to not close when different animations were applied on multiple stacked modals. I've uploaded a new version on npm (v0.0.5).

Could you:

The demo page has been updated aswel so you can check it out: https://greenflag31.github.io/modal-library/ngx-modal-ease

Thank you

jagabs commented 7 months ago

hey working now as expected!

It was reproducible with both esc and button modalService to close. I was using different components for every modal. Yes my animations are different.