search

GreenFrogSB / LMDS

LMDS - Linux Media Delivery System
https://greenfrognest.com
GNU General Public License v3.0
210 stars 45 forks source link

Can't use pihole dhcp server #39

Closed Junn-Sorran closed 2 years ago

Junn-Sorran commented 2 years ago

Hello,

It's not possible to use the dhcp service provided with the pihole in the stack due to the network configuration. The official pihole documentation provide multiple solutions for this problem, do you think it would be possible to implement one with the stack? https://docs.pi-hole.net/docker/dhcp/

Thanks!

GreenFrogSB commented 2 years ago

Hi Junn, Change implemented to the code as per article https://docs.pi-hole.net/docker/dhcp/ "Inside your docker-compose.yml remove all ports and replace them with: network_mode: host" Pihole template updated

Junn-Sorran commented 2 years ago

That was fast thank you! However i had to make the change manually in portainer to switch to host network? I pulled, updated and redeployed the stack but i kept the old configuration, do you know why?

GreenFrogSB commented 2 years ago

Yes, pull only update templates, therefore changes I make to the project do not owerwrite users custom changes they did.

When you deploy or add/remove containers, script asks you to keep current or update from template. If you choose to use template your changes will be owerwritten with project defaults, this is also why it is not a default option as in many cases you want to keep changes you made constant even if I change a template at some point for whatever reason.

You should also change relevant files inside services folder to keep your changes constant.

On Fri 15 Apr 2022, 4:12 p.m. Junn-Sorran, @.***> wrote:

That was fast thank you! However i had to make the change manually in portainer to switch to host network? I pulled, updated and redeployed the stack but i kept the old configuration, do you know why?

— Reply to this email directly, view it on GitHub https://github.com/GreenFrogSB/LMDS/issues/39#issuecomment-1100167366, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFVEPVEPJRJEYDCUY4VEWLVFGBOFANCNFSM5TLSI5TA . You are receiving this because you commented.Message ID: @.***>

Junn-Sorran commented 2 years ago

Thank you it worked!

As a side note, can you add the LMD_BACKUP directory to the gitignore?